PADV-1971: Remove Course selection on CoursesPage #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bra-i-am
approved these changes
Jan 16, 2025
AuraAlba
requested changes
Jan 16, 2025
| }) => ( | ||
| <Row className="justify-content-center my-4"> | ||
| <Col> | ||
| <DataTable | ||
| isSelectable | ||
| isSelectable={isSelectable} |
There was a problem hiding this comment.
If this is not a custom prop or you don't modify its value is better to pass just props: https://github.com/Pearson-Advance/frontend-app-institution-portal/blob/master/src/features/Main/Table/index.jsx#L20
so you don't have to define every prop
AuraAlba
approved these changes
Jan 16, 2025
kuipumu
force-pushed
the
vue/PADV-1971
branch
from
7654d62 to
7372158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
Description
This PR removes the ability to select and submit the Courses from the CoursesPage list, this is because this list should only be used to get a list of Classes from a Course on the list.