Crypto monitor josantonius #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
commented
Oct 9, 2018
|
|
||
| $apiKey = 'your-coin-api-key'; | ||
| $apiKey = '4E861687-19D6-4894-87B9-E785B1EE3900'; |
There was a problem hiding this comment.
Is this API key free-trial? If it's, I think it's fine to expose this key here.
peter279k
commented
Oct 9, 2018
|
|
||
| $params = self::$providers[$config->provider][$config->type]; | ||
|
|
||
| switch ($config->type) { |
There was a problem hiding this comment.
How about enhancing this type condition?
I think using the switch...case is not the proper way to do.
If we have the many types to do the different action, the swittch condition will be very long.
peter279k
commented
Oct 9, 2018
| @@ -12,14 +13,11 @@ | |||
|
|
|||
| class GetAllRate implements ProviderResource | |||
| { | |||
| private $apiKey; | |||
| public $config; | |||
There was a problem hiding this comment.
Let $config be public and it means we can modify this at any time from this class instance.
How about using the private/protected $config?
And we can also add the setConfig and getConfig to allow us to modify this private/protected $config :).
peter279k
commented
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new branch that @josantonius creates.
I just create this PR for helping us to do the code review :).
@josantonius, can you fix the Travis CI build and
README.mdconflicts? Thanks.