Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation of "subset" tag #1294

Open
xnrxng opened this issue Nov 21, 2024 · 7 comments
Open

Automation of "subset" tag #1294

xnrxng opened this issue Nov 21, 2024 · 7 comments

Comments

@xnrxng
Copy link

xnrxng commented Nov 21, 2024

When performing DEA for experiments that need to be subset, a "SUBSET" tag under the category of "study design" is manually added to the experimental tags.

Would it be possible that when it is detected that a curator used the -subset flag when running diffExAnalyze, the "SUBSET" tag is automatically added to the experiment?

Example: GSE256180

@ppavlidis
Copy link
Collaborator

We discussed this in the curator meeting last week, and I suggested that maybe we don't need this tag at all, since we can infer that it was subset based on the DEA? And I'm not sure what use the tag has anyway.

So we could probably show the 'subset' status computed at runtime based on the DEA, but I'm not sure that's useful, let us know.

@xnrxng
Copy link
Author

xnrxng commented Nov 21, 2024

It seems like Neera does use the "subset" tag for her work, so it would be problematic to remove the tag.

@ppavlidis
Copy link
Collaborator

Still, because the status can be inferred, so it could be filled in - anyway, I agree it shouldn't be done manually.

@neerapatadia
Copy link

neerapatadia commented Nov 21, 2024

Sorry, misinterpreted this as referring to the subset annotations as a whole - I don't use the tag at all as I can infer it from the metadata. I'm fine if it's removed.

@SalvaSherif2532
Copy link
Contributor

Okay in that case, I would be in favor of removing it all together unless we can think of some use case.

@xnrxng
Copy link
Author

xnrxng commented Nov 28, 2024

In that case, I'll update the wiki about the deprecation of the subset tag. The subset tag should also be mass-removed from experiments then.

@xnrxng
Copy link
Author

xnrxng commented Nov 28, 2024

The term [SUBSET] is a TGEMO term. Should the ontology term be deprecated as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants