update to 1.19 and add custom sounds #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inb4 pixel has a private fork fully updated and working and compatible with everything
if anyone knows a better way to lay out the song data let me know lol
dont tell anyone but i dont work with github ci ever so i thought i had to push updated workflows to main but i guess i have to push to the pr branch :D oops!
out with the old in with the new. flags are loaded the easy way (synchronously :D)
b-b-but it works on my machine :(
wooo no breaking changes
This reverts commit cb67852.
- no more ShouldInitialize() because it ended up running redundant checks - no more NoteDir, no more RootDir, everything is just poured into UserData like other mods 🤢 - changed name from a4.ogg to OCanadaHitSound.ogg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listen to o canada while you click flags 🇨🇦