Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add new message.CommandName filters #159

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

PaulSonOfLars
Copy link
Owner

@PaulSonOfLars PaulSonOfLars commented May 9, 2024

What

This change adds a few new message filters to allow MessageHandlers to function similarly to CommandHandlers. With this new change, a CommandHandler can be considered a specialised MessageHandler (with command filters pre-applied).

Worth noting that with this change, the CommandHandler type becomes significantly less useful; maybe the type should be removed, and the NewCommand method should be left simply as a wrapper around NewMessage?

Impact

  • Are your changes backwards compatible? Yes; unless we choose to remove the CommandHandler type.
  • Have you included documentation, or updated existing documentation? Yes
  • Do errors and log messages provide enough context? Yes

@PaulSonOfLars PaulSonOfLars changed the title Add new message.CommandName filters [Draft] Add new message.CommandName filters May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant