Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Entire Menu Items Clickable. #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NIKHIL-PALL
Copy link

Related Issue

Fixes #344

Description

Make entire menu items clickable by moving padding to Link component. This change won't effect any styling of the list items. List items will work as before.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before :

old.mp4

After :

updated.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kaam-do ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:00pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@NIKHIL-PALL NIKHIL-PALL changed the title Make Entire Menu Items Clickable. fix: Make Entire Menu Items Clickable. Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Adding link on entire List item instead of only text
1 participant