Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer #250

Merged
merged 4 commits into from
Jun 20, 2024
Merged

footer #250

merged 4 commits into from
Jun 20, 2024

Conversation

siddhant-2002
Copy link
Contributor

footer color changed

copyright updated

margin n padding changed

footer color changed

copyright updated

margin n padding changed
Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kaam-do ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:14am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@siddhant-2002
Copy link
Contributor Author

image

@PatilHarshh
Copy link
Owner

what changes you did ! just color changing ? which do not suites the site ?

@siddhant-2002
Copy link
Contributor Author

image

your footer is looking like this previously

I have changed the whole padding put all content at the center and flex is wrapped when we shrink for responsive all content is getting one after another column wise

like this
image

and colour I have used is complimentary color to your color its usually used with the yellow color it looks good ig if you will see carefully with whole website

image

@siddhant-2002
Copy link
Contributor Author

any updates ? whats your openion @PatilHarshh

@PatilHarshh
Copy link
Owner

no ! really like existing one ! do feels existing one is good ! any other changes you want to perform there ?

@siddhant-2002
Copy link
Contributor Author

last footer line copyright thing i think that would be ok at the center and 2024 copyright added

and responsiveness of footer also done if you think it is ok you should merge my pr I will change color again and do next request

color changed again

made footer responsive

and copyright fixed
@siddhant-2002
Copy link
Contributor Author

image

image

@PatilHarshh PatilHarshh merged commit e6dc0d5 into PatilHarshh:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants