Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPML2013a-fuller schema, with version of BioPAX as used in GPML2013a #13

Closed
wants to merge 48 commits into from

Conversation

ariutta
Copy link
Collaborator

@ariutta ariutta commented Jun 3, 2017

I made a few changes so that XSD processors can handle actual GPML2013a, which has its own version of BioPAX that differs from the BioPAX Level 3 spec.

@egonw
Copy link
Collaborator

egonw commented Jun 4, 2017

XML Namespaces FTW :)

@ariutta
Copy link
Collaborator Author

ariutta commented Jun 4, 2017

I didn't merge this pull request myself, because I want to give time for feedback on this update (pinging @mkutmon and @AlexanderPico). This is still GPML2013a: the update just makes the XSD more closely reflect our actual GPML2013a GPML.

@AlexanderPico
Copy link
Collaborator

I only see one real difference: removing processContents="skip" from here:
https://github.com/PathVisio/GPML/pull/13/files#diff-36fb8619457b831815471a4174808d12R569

What are the consequences of that change?

The rest is... stuff that... hmm. I'm not going to even bother guessing :) When is this GPML2013a-biopax.xsd used in practice? Does this affect anyone using it today?

@ariutta
Copy link
Collaborator Author

ariutta commented Jun 5, 2017

I'm using it to provide types and autocompletion in my code editor.

@mkutmon
Copy link
Contributor

mkutmon commented Jun 5, 2017 via email

@ariutta
Copy link
Collaborator Author

ariutta commented Jun 5, 2017

Hi Tina! Sure, we can have a hangout. I can meet anytime this week at 10 or 11am SF time (I think that's 7 or 8pm Maastricht time?). Just let me know.

By the way, this change is not for GPML2017. It's still for GPML2013a. Are you aware of any existing tools that rely on this XSD file? Does PathVisio-Java need to be tested with this updated version?

@mkutmon
Copy link
Contributor

mkutmon commented Jun 6, 2017 via email

ariutta and others added 9 commits June 14, 2017 20:14
Changed XSD to only display a single top-level element, following the advice from this article:

>> Normally it is desired to have only one possible top-level element in an XML instance, and so this constraint is imposed in the schema by only having one global element definition.
from http://www.codalogic.com/lmx/xsd-overview.html

Cleaned up BiopaxRef definitions. We don't have BiopaxRef as an attribute: it's always an element.
@ariutta
Copy link
Collaborator Author

ariutta commented Nov 2, 2017

I added a new schema GPML2013a-fuller that I needed in order to use a certain 3rd-party library. There's no need for any of our tooling to change, because the GPML2013a schema is unchanged.

@ariutta ariutta changed the title Specify version of BioPAX as used in GPML2013a Add GPML2013a-fuller schema, with version of BioPAX as used in GPML2013a Nov 2, 2017
@ariutta
Copy link
Collaborator Author

ariutta commented Nov 2, 2017

I split up this pull request into two separate pull requests: 23 and 24.

@ariutta ariutta closed this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants