Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR to validate new test command in CI #95

Closed
wants to merge 6 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 28, 2024

Expect this to fail.


Update: It failed 👍

image

This way, we avoid other `os_log` calls getting in between `os_log` and
`dump` and breaking the association between the two which makes the logs
harder to understand.
@mokagio mokagio changed the base branch from mokagio/dx-additions to master November 28, 2024 01:07
@mokagio mokagio force-pushed the mokagio/verify-setpipefail-in-gh-actions branch from d33417e to db0661f Compare November 28, 2024 01:08
@mokagio
Copy link
Contributor Author

mokagio commented Nov 28, 2024

Note: I had to force push to trigger CI.

image

That's because CI is configured to run only on PR against master. That's something we might want to change later.

@mokagio mokagio closed this Nov 28, 2024
@mokagio mokagio deleted the mokagio/verify-setpipefail-in-gh-actions branch November 28, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant