Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in computing absolute value with cupy datatype #480

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

brownbaerchen
Copy link
Contributor

Seems I was too eagerly deleting stuff in #469 ... sorry about that! It's a shame we can't get the GPU tests with multiple GPUs to work.

@pancetta
Copy link
Member

What's the matter with multi-GPU tests?

@brownbaerchen
Copy link
Contributor Author

What's the matter with multi-GPU tests?

I don't remember exactly, maybe @jakob-fritz does. Maybe it was related to job submission?

@jakob-fritz
Copy link
Collaborator

I don't recall, we tried multi-GPU at all. So I don't know if (and what) issues arise with multi-GPU tests. I know, that we tried the single-GPU test on HPC, but have no insight in any multi-GPU attempts.

@pancetta
Copy link
Member

Could you @brownbaerchen set up a multi-GPU test, then? Not here, but in another PR?

@pancetta pancetta merged commit f46209f into Parallel-in-Time:master Sep 13, 2024
93 checks passed
@brownbaerchen
Copy link
Contributor Author

Could you @brownbaerchen set up a multi-GPU test, then? Not here, but in another PR?

We have such a test here, but we skip it because we don't know how to run it.

@brownbaerchen brownbaerchen deleted the cupy_dtype_fix branch September 13, 2024 11:16
@pancetta
Copy link
Member

Not sure I understand the problem..? Why is it difficult to run it if you are on JUWELS?

@brownbaerchen
Copy link
Contributor Author

Currently, we use this script to launch pytest on JUWELS. Usually, we do MPI based tests by executing shell commands from within python scripts. But I am not sure that we can launch a larger job from within the job. I believe we tried posting srun commands, but I am not totally sure. Also, the first job that runs pytest will collect the coverage report, how does that work when the code is run by a different job on a different node? I am sure it's possible but we decided to postpone it. Maybe we can try again now that we are happy with the rest of the GitLab integration.

@pancetta
Copy link
Member

Well, we do have multiple pytest calls in the pipeline anyway, so I guess this should be possible within a single step? @jakob-fritz ideas are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants