Coverage-report now uses less restricted file-names #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakob-fritz
added
the
girl scout rule
jakob-fritz
changed the title
|
Went with the second option (less restrictive file-names when the report is created). The coverage-files from individual tests and data-dir now does not include the python-version anymore to make updating easier, as fewer places need changing. Now this is only determined by which jobs upload artifacts. |
brownbaerchen
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage-file created in Gitlab was named without the "3.10" suffix. This lead to the issue, that it was not taken into account, when creating the whole coverage report.
This issue now solves this, but changing the name of the created coverage-file. An alternativ would be to remove the need for the suffix "3.10" in another file (
.github/workflows/postprocess.ymlline 36).Then, the coverage-report should include the coverage information from the cupy-tests.