Fixed some issues with transfer classes #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transfer classes are poorly tested and are silently not compatible with some parts of the code.
#421 tracks some of these issues. This PR addresses a few. Namely, the new implementation of
imex_meshviaMultiComponentMeshwas causing some issues which I fixed in some transfer classes. I didn't check all. I added some tests to increase coverage and also reduced code duplication in some transfer classes.I mainly need the transfer class for mpi4py-fft, which now does what I need. So I am not sure if I will continue working on fixing the transfer classes beyond this PR.