Skip to content

Commit

Permalink
small edits for codecov
Browse files Browse the repository at this point in the history
  • Loading branch information
ikrom96git committed Jan 12, 2024
1 parent c543234 commit a8b1322
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 18 deletions.
4 changes: 2 additions & 2 deletions pySDC/projects/Second_orderSDC/check_data_folder.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
import os # pragma: no cover

folder_name = "./data"
folder_name = "./data" # pragma: no cover

This comment has been minimized.

Copy link
@brownbaerchen

brownbaerchen Jan 12, 2024

Contributor

Please only exclude functions that only plot stuff. We don't need 100% coverage. It's fine not to test imports. We'd rather accept lower coverage than clutter the code with these statements :D


# Check if the folder already exists
if not os.path.isdir(folder_name): # pragma: no cover
Expand Down
15 changes: 8 additions & 7 deletions pySDC/projects/Second_orderSDC/harmonic_oscillator_run_points.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
from pySDC.projects.Second_orderSDC.harmonic_oscillator_params import get_default_harmonic_oscillator_description
from pySDC.projects.Second_orderSDC.stability_simulation import compute_and_generate_table

Check warning on line 3 in pySDC/projects/Second_orderSDC/harmonic_oscillator_run_points.py

View check run for this annotation

Codecov / codecov/patch

pySDC/projects/Second_orderSDC/harmonic_oscillator_run_points.py#L1-L3

Added lines #L1 - L3 were not covered by tests

'''
This script generates table for the given points to compare in what quadrature type,
number of nodes and number of iterations the SDC iteration is stable or not.
Additional parameter:
To save the table set: save_points_table=True
Change filename: points_table_filename='FILENAME' by default: './data/point_table.txt'
'''

if __name__ == '__main__':
'''
This script generates table for the given points to compare in what quadrature type,
number of nodes and number of iterations the SDC iteration is stable or not.
Additional parameter:
To save the table set: save_points_table=True
Change filename: points_table_filename='FILENAME' by default: './data/point_table.txt'
'''
# Get default parameters for the harmonic osicillator problem
description = get_default_harmonic_oscillator_description()
# Additonal params to compute stability points
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@
from pySDC.projects.Second_orderSDC.harmonic_oscillator_params import get_default_harmonic_oscillator_description
from pySDC.projects.Second_orderSDC.stability_simulation import compute_and_generate_table

Check warning on line 3 in pySDC/projects/Second_orderSDC/harmonic_oscillator_run_stab_interval.py

View check run for this annotation

Codecov / codecov/patch

pySDC/projects/Second_orderSDC/harmonic_oscillator_run_stab_interval.py#L1-L3

Added lines #L1 - L3 were not covered by tests

'''
To compute maximum stable values for SDC and Picard iterations for the purely oscillatory case with
no damping (mu=0)
Additional parameter:
To save the table set: save_interval_file=True
Change filename: interval_filename='FILENAME' by default: './data/stab_interval.txt'
Output:
it generates to compare with different values of M (number of nodes) and K (maximal number of iterations)
'''

if __name__ == '__main__':
'''
To compute maximum stable values for SDC and Picard iterations for the purely oscillatory case with
no damping (mu=0)
Additional parameter:
To save the table set: save_interval_file=True
Change filename: interval_filename='FILENAME' by default: './data/stab_interval.txt'
Output:
it generates to compare with different values of M (number of nodes) and K (maximal number of iterations)
'''
# Ger default parameters
description = get_default_harmonic_oscillator_description()
# Additional parameters to compute stability interval on the kappa
Expand Down

0 comments on commit a8b1322

Please sign in to comment.