Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack Chain Migration: /turf #27530

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

warriorstar-orion
Copy link
Contributor

What Does This PR Do

This PR migrates /turf and its subtypes to the new attack chain.

Why It's Good For The Game

Important foundational type to move over, unblocks other contributors.

Testing

In progress.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

Not sure what to put here. It's very possible that some new attack paths have been opened up -- things that wouldn't cause an attack action that now do because, well, they're on the correct code path now. Will update the CL once I do some more testing.

🆑
add: Added new things
/:cl:

@Burzah Burzah added the Attack Chain Migration Refactoring of legacy attack chain items label Dec 3, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting review This PR is awaiting review from the review team label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Attack Chain Migration Refactoring of legacy attack chain items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants