Manually reset attribute map on restoring player instance #11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 4, 2024
Closed
kennytv
approved these changes
Nov 6, 2024
| + this.attributes.values().forEach(AttributeInstance::removeModifiers); | ||
| + } | ||
| + | ||
| + public void removeAllTransientModifiers() { |
There was a problem hiding this comment.
This method scared me for a second, should add a note that we expect the getters to return copies
Spigots reuse of the entity instances causes the server to try to copy a players existing attributes back onto itself, which causes an error. We'll manually clear the applicable attribute modifiers, but, in the long run, we should just revert out of the broken behavior of trying to reuse ServerPlayer instances.
lynxplay
force-pushed
the
fix/attributes-restorefrom
branch
from
a6c4f1c
to
35bebb7
Compare
lynxplay
requested changes
Nov 9, 2024
Do not break API modifier expectations of lasting through death.
electronicboy
added
the
build-pr-jar
This was
unlinked from
issues
Nov 17, 2024
Closed
|
Closing this as the immediate issue has been solved by upstream. The API needs to be fleshed out to support plugins to set attribute modifiers that do/do not persist through death. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spigots reuse of the entity instances causes the server to try to copy a players existing attributes back onto itself, which causes an error.
We'll manually clear the applicable attribute modifiers, but, in the long run, we should just revert out of the broken behavior of trying to reuse ServerPlayer instances.
Download the paperclip jar for this pull request: paper-11580.zip