Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ticket on player join to avoid chunk load-unload-load cycle #11398

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add ticket on player join to avoid chunk load-unload-load cycle #11398

wants to merge 2 commits into from

Commits on Sep 13, 2024

  1. Add ticket on player join to avoid chunk load-unload-load cycle 

    Adding the entity will add and then immediately remove an entity load ticket, which would result in the chunk loading and then unloading before being loaded again once the player chunk loader reacts (delay can vary based on rate limit configs)

By adding a ticket with a short removal delay we attempt to keep the chunk loaded until the player chunk loader reacts, but this is not a guarantee due to the aforementioned rate limit configs. Plugins should still handle load/unload events as normal, however this will reduce redundant calls.

The delay is currently set to 2 seconds, however we may want to adjust this before merging
    @jpenilla
    jpenilla committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fcf48a9 View commit details
    Browse the repository at this point in the history

  2. adjust delay to 5s

    @jpenilla
    jpenilla committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a136173 View commit details
    Browse the repository at this point in the history