Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nom 7 to get a clean rustsec audit #36

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

jcfj
Copy link
Contributor

@jcfj jcfj commented Oct 10, 2024

Currently, using classfile-parser results in cargo audit complaining a little bit about a transitive dependency of the old nom.

Crate:     lexical-core
Version:   0.7.6
Warning:   unsound
Title:     Multiple soundness issues
Date:      2023-09-03
ID:        RUSTSEC-2023-0086
URL:       https://rustsec.org/advisories/RUSTSEC-2023-0086
Dependency tree:
lexical-core 0.7.6
└── nom 5.1.3
    └── classfile-parser 0.3.8

Sadly, the upgrade is far from small, since nom 7 removed macros.

@jcfj jcfj changed the title Upgrade to nom 7 to get a clean rusetsec audit Upgrade to nom 7 to get a clean rustsec audit Oct 10, 2024
@Palmr
Copy link
Owner

Palmr commented Oct 10, 2024

Sadly, the upgrade is far from small, since nom 7 removed macros.

Indeed, this is something I had a local branch for a long time ago but didn't finish.
So thanks for taking the time and effort 👍

@Palmr Palmr merged commit ea931ad into Palmr:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants