Skip to content

Commit

Permalink
Revert "netfilter:Notify user space on creating sysfs file"
Browse files Browse the repository at this point in the history
This causes userspace to receive xt_idletimer events but without
params, in turn making netd unhappy.
system/netd/server/NetlinkHandler.cpp:132 constantly spams the log
with "NetlinkEvent::FindParam(): Parameter '...' not found".

xt_hardidletimer subsystem is also not handled in netd, so avoid
flooding uevent here too.

This reverts commit 3d6aa17.

Change-Id: I014ac79bdff6a8b356df898132cd063e1e9a0cbb
Signed-off-by: Yaroslav Furman <[email protected]>
Signed-off-by: Rizky Benggolo <[email protected]>
Signed-off-by: PainKiller3 <[email protected]>
  • Loading branch information
difr authored and PainKiller3 committed May 27, 2021
1 parent 463cc2e commit 5acd26a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions net/netfilter/xt_HARDIDLETIMER.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,6 @@ static int hardidletimer_tg_create(struct hardidletimer_tg_info *info)
pr_debug("couldn't add file to sysfs");
goto out_free_attr;
}
/* notify userspace */
kobject_uevent(hardidletimer_tg_kobj, KOBJ_ADD);

list_add(&info->timer->entry, &hardidletimer_tg_list);

Expand Down
2 changes: 0 additions & 2 deletions net/netfilter/xt_IDLETIMER.c
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,6 @@ static int idletimer_tg_create(struct idletimer_tg_info *info)
pr_debug("couldn't add file to sysfs");
goto out_free_attr;
}
/* notify userspace */
kobject_uevent(idletimer_tg_kobj, KOBJ_ADD);

list_add(&info->timer->entry, &idletimer_tg_list);

Expand Down

0 comments on commit 5acd26a

Please sign in to comment.