weight parallel #773
Open
weight parallel #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
||
|
|
||
| if model_parallel_size > 1: | ||
| self.qkv_mp = nn.LayerList([fleet.meta_parallel.ColumnParallelLinear(self.dim, 3 * self.dim, gather_output=False, has_bias=True) for i in range(num_layers)]) |
There was a problem hiding this comment.
from fleet.meta_parallel import RowParallelLinear
from fleet.meta_parallel import ColumnParallelLinear
被频繁使用了，应该预先import as吧
There was a problem hiding this comment.
from fleet.meta_parallel import RowParallelLinear
from fleet.meta_parallel import ColumnParallelLinear
from fleet.meta_parallel import RowParallelLinear
from fleet.meta_parallel import ColumnParallelLinear
改成这样
|
|
||
| hcg = fleet.get_hybrid_communicate_group() | ||
| dp_degree = hcg.get_data_parallel_world_size() | ||
| if dp_degree > 1 and self.do_classifier_free_guidance: |
There was a problem hiding this comment.
dp_degree > 1 and self.do_classifier_free_guidance:这个判断出现了两次了！
这样不好！建议声明一个临时变量！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.