Skip to content

Commit

Permalink
Remove deprecated API for pageGrabberEnabled (#49)
Browse files Browse the repository at this point in the history
* Remove deprecated API for `pageGrabberEnabled`

* Bump version number to 1.2.1
  • Loading branch information
radazzouz authored Jul 30, 2021
1 parent 1666c21 commit 05843b2
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 18 deletions.
6 changes: 3 additions & 3 deletions examples/cordova/PSPDFKit-Demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions examples/ionic/PSPDFKit-Demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pspdfkit-cordova",
"version": "1.2.0",
"version": "1.2.1",
"description": "PSPDFKit Cordova Plugin for Android and iOS",
"cordova": {
"id": "pspdfkit-cordova",
Expand Down
2 changes: 1 addition & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android" id="pspdfkit-cordova" version="1.2.0">
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android" id="pspdfkit-cordova" version="1.2.1">
<engines>
<engine name="cordova" version="&gt;=6.3.1" />
</engines>
Expand Down
10 changes: 0 additions & 10 deletions src/ios/PSPDFKitPlugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -1131,16 +1131,6 @@ - (NSNumber *)shouldAskForAnnotationUsernameAsJSON {
return @(_pdfController.configuration.shouldAskForAnnotationUsername);
}

- (void)setPageGrabberEnabledForPSPDFViewControllerWithJSON:(NSNumber *)pageGrabberEnabled {
[_pdfController updateConfigurationWithBuilder:^(PSPDFConfigurationBuilder *builder) {
builder.pageGrabberEnabled = pageGrabberEnabled.boolValue;
}];
}

- (NSNumber *)pageGrabberEnabledAsJSON {
return @(_pdfController.configuration.pageGrabberEnabled);
}

- (void)setPageLabelEnabledForPSPDFViewControllerWithJSON:(NSNumber *)pageLabelEnabled {
[_pdfController updateConfigurationWithBuilder:^(PSPDFConfigurationBuilder *builder) {
builder.pageLabelEnabled = pageLabelEnabled.boolValue;
Expand Down

0 comments on commit 05843b2

Please sign in to comment.