[FEAT] 마이페이지 > 활동중인 모임 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 최신순 2개만 - feed형일때 system메시지 제외
soobin-k
added
🍎 ConfigureUI
dlrjswns
approved these changes
May 7, 2023
| recruitButton | ||
| .rx.tap | ||
| .asDriver() | ||
| .drive(with: self) { owner, _ in | ||
| let vc = DetailRecruitmentViewController(plubbingID: owner.viewModel.plubbingID) | ||
| let vc = DetailRecruitmentViewController(plubbingID: owner.viewModel.plumbingID) |
There was a problem hiding this comment.
Suggested change
| let vc = DetailRecruitmentViewController(plubbingID: owner.viewModel.plumbingID) | |
| let vc = DetailRecruitmentViewController(plubbingID: owner.viewModel.plubbingID) |
오타 있는거같아요 !!
| @@ -52,6 +80,19 @@ final class ActiveMeetingViewModel { | |||
| ) | |||
| } | |||
|
|
|||
| private func handleMyTodoInfo(todoInfo: TodoInfo) { | |||
| todoList = todoInfo.todoContent | |||
| .prefix(2) | |||
There was a problem hiding this comment.
string에서 사용하면 지정된 개수만큼 앞에서부터 잘라주고
배열에서 사용하면 처음부터 지정된 개수만큼의 요소를 반환해줘요!
기획상으로 최대 2개의 todo, feed만 보여줘야해서 저렇게 사용했습니다~!
|
|
||
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| contentView.frame = contentView.frame.inset(by: UIEdgeInsets(top: 4, left: 16, bottom: 4, right: 16)) |
There was a problem hiding this comment.
이 부분은 왜 layoutSubviews안에 정의하신건가요 ??
There was a problem hiding this comment.
음.. 그러네요, contentView의 inset을 설정하기보다, wholeStackView의 constraint로 inset을 설정하면 좋을 것 같아요.
There was a problem hiding this comment.
cell의 contentView에 radius가 잡혀있어서 inset을 주려면 또다른 뷰로 감싸줘야해서 저렇게 구현하긴 했는데
수정하겠습니다!
WhiteHyun
approved these changes
May 7, 2023
|
|
||
| struct FeedInfo: Codable { | ||
| let totalElements: Int | ||
| let last: Bool |
There was a problem hiding this comment.
isLast로 변경하는 건 어때요? 저희 대부분의 모델에서는 isLast로 표기하고 있어요!
| @@ -10,33 +10,61 @@ import Foundation | |||
| import RxSwift | |||
| import RxCocoa | |||
|
|
|||
| protocol ActiveMeetingViewModelType { | |||
| // MARK: Property | |||
| var plumbingID: Int { get } | |||
| feedList = feedInfo.feedList | ||
| .filter { $0.viewType != .system } | ||
| .prefix(2) | ||
| .map { $0 } |
|
|
||
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| contentView.frame = contentView.frame.inset(by: UIEdgeInsets(top: 4, left: 16, bottom: 4, right: 16)) |
There was a problem hiding this comment.
음.. 그러네요, contentView의 inset을 설정하기보다, wholeStackView의 constraint로 inset을 설정하면 좋을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
마이페이지 > 활동중인 모임 기능을 구현했습니다.
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
RPReplay_Final1683436577.mov
📮 관련 이슈