댓글 작성란 - 프로필 이미지 UI 구현 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHyun
added
🍎 ConfigureUI
soobin-k
approved these changes
Apr 24, 2023
| } | ||
| } | ||
|
|
||
| private func bind() { | ||
| // 프로필 이미지 설정 | ||
| AccountService.shared.inquireMyInfo() |
There was a problem hiding this comment.
네트워크 통신 부분은 뷰모델에서 처리하는 것이 좋을 것 같습니다!
내 정보 데이터가 여러 군데에서 쓰일 것 같은데, 추후 로컬에 저장하는 형태로 바꿔봐도 좋을 것 같습니다!!
There was a problem hiding this comment.
내 정보 데이터가 여러 군데에서 쓰일 것 같은데, 추후 로컬에 저장하는 형태로 바꿔봐도 좋을 것 같습니다!!
저도 그걸 고려하고있었어요. 그래서 사용자 정보 데이터를 User라는 객체로 구성해서 UserManager가 갖고있게 하는 것이 어떨까 싶어요.
어떻게 생각하시나요?
There was a problem hiding this comment.
좋은 것 같습니다!! 이거 제가 마이페이지 작업하면서 추가해놓을까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈