-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
댓글 수정 기능 구현 #303
Merged
Merged
댓글 수정 기능 구현 #303
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
41685d4
[ADD] Implement edit button binding
WhiteHyun 8982777
[REFACTOR] Refactor ReplyView to CommentOptionDecoratorView
WhiteHyun 616a474
[REFACTOR] CommentOptionBottomSheetVC's initializer
WhiteHyun 15bab7b
[REFACTOR] Integrate ReplyID and recentSelectedCommentID
WhiteHyun c4e6c15
[REFACTOR] Integrate DeleteOption, EditOption
WhiteHyun d0b2802
[FEAT] Insert comment's text when try to edit comments
WhiteHyun 2f74970
[ADD] Add EditCommentUseCase and inject to ViewModel
WhiteHyun dc77b71
[FEAT] Implement comment editing feature
WhiteHyun f881695
[FIX] Reset default values for targetID and commentOptions after API …
WhiteHyun c5a2a0f
[FIX] Fix issue with Decorator View not disappearing after comment su…
WhiteHyun a5856fc
[ADD] Add Comments
WhiteHyun d0e153f
[FIX] Fix issue with View not updating after successful call to comme…
WhiteHyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// | ||
// EditCommentUseCase.swift | ||
// PLUB | ||
// | ||
// Created by 홍승현 on 2023/04/19. | ||
// | ||
|
||
import RxSwift | ||
|
||
protocol EditCommentUseCase { | ||
func execute(plubbingID: Int, feedID: Int, commentID: Int, content: String) -> Observable<CommentContent> | ||
} | ||
|
||
final class DefaultEditCommentUseCase: EditCommentUseCase { | ||
|
||
func execute(plubbingID: Int, feedID: Int, commentID: Int, content: String) -> Observable<CommentContent> { | ||
FeedsService.shared.updateComment(plubbingID: plubbingID, feedID: feedID, commentID: commentID, comment: content) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이런식으로 하면 훨씬 가독성있겠네요👍