Skip to content

Commit

Permalink
internal_link test [nfc]: Give test groups distinct names
Browse files Browse the repository at this point in the history
The organization of this code's test cases is a bit scattered;
partly because they were ported from tests written for the
legacy zulip-mobile RN app, which themselves accumulated in layers
over time.  (After all, one doesn't want to drop one of these tests
in a refactoring unless taking the time to be sure its substance is
covered by a surviving test.)

It's potentially confusing having several groups with the same name,
though.  Fix that by picking different names for all but one of them.

The name collision was originally noted by Zixuan in zulip#1059.
  • Loading branch information
gnprice authored and PIG208 committed Dec 11, 2024
1 parent cf19d68 commit 5a1caac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/model/internal_link_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ void main() {
}
}

group('parseInternalLink', () {
group('parseInternalLink is-internal', () {
final streams = [
eg.stream(streamId: 1, name: 'check'),
];
Expand Down Expand Up @@ -398,7 +398,7 @@ void main() {
});
});

group('parseInternalLink', () {
group('parseInternalLink again', () { // TODO perhaps unify with tests above
group('topic link parsing', () {
final stream = eg.stream(name: "general");

Expand Down

0 comments on commit 5a1caac

Please sign in to comment.