Fix that style objects cannot be passed to element constructors #2685
+24
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NewStyle() method could not return style objects as value arguments, when $returnObject is true, like in the Cell element.
hazington
changed the title
…yle value is returned and not a clone.
|
It took me a while to find the cause of the phpstan errors. Never imagined that there would be such a long list of ignored errors. |
hazington
changed the title
|
@Progi1984 Is there a chance to look over this pull request? I see that PhpWord transforms to a strict typed library and thus elements should accept style objects. This is also necessary for a better html to word implementation. At the moment you can't pass style objects since they are ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I generally prefer to use style objects over style arrays in elements. But, if you pass a
\PhpOffice\PhpWord\Style\Cellstyle element to the\PhpOffice\PhpWord\Element\Cellconstructor then the$returnObject: trueargument of thesetNewStyle()method in the constructor completely ignores the passed style element, because thesetNewStyle()method only checks if$styleValueis an array and returns$styleObjectas empty style object otherwise. Imho, if$styleValueis a style object with the same type as$styleObjectthen the$returnObject: trueshould also be "ignored" and the passed style object should then be returned instead of the empty base style object.Fixes # (issue)
Checklist:
I have updated the documentation to describe the changes(not applicable, bugfix did not change the behavior)