TEST to look at Gh build vs tip

.github/workflows/gradle.yml

@@ -1,19 +1,70 @@
-name: Java CI
+# This workflow will build a Java project with Gradle and cache/restore any dependencies to improve the workflow execution time
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-gradle
 
-on: [push]
+name: Build PCGen with Gradle
+
+on:
+  push:
+    branches: [ "gh_build" ] # use current branch for testing purposes only
+  pull_request:
+    branches: [ "master" ]
 
 jobs:
   build:
 
     runs-on: ubuntu-latest
+    permissions:
+      checks: write
+      pull-requests: write
 
     steps:
-    - name: Checkout Code
-      uses: actions/checkout@v3
-    - name: Set up JDK 17
-      uses: actions/setup-java@v3
-      with:
-        distribution: 'temurin'
-        java-version: '17'
-    - name: Build with Gradle
-      run: ./gradlew build
+      - uses: actions/checkout@v4
+
+      - name: Set up JDK 21
+        uses: actions/setup-java@v4
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+          cache: gradle
+          cache-dependency-path: |
+            build.gradle
+            code/gradle/autobuild.gradle
+            code/gradle/distribution.gradle
+            code/gradle/release.gradle
+            code/gradle/reporting.gradle
+
+      # Configure Gradle for optimal use in GitHub Actions, including caching of downloaded dependencies.
+      # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+        with:
+          cache-disabled: false
+          cache-read-only: false
+          cache-overwrite-existing: true
+
+      - uses: actions/cache@v4
+        with:
+          path: |
+            build/classes
+            build/jre
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+          restore-keys: |
+            ${{ runner.os }}-gradle-
+
+      - name: Build with Gradle Wrapper
+        run: ./gradlew build test slowtest
+
+      - name: Publish Test Results
+        uses: EnricoMi/publish-unit-test-result-action@v2
+        if: always()
+        with:
+          files: |
+            build/test-results/**/*.xml
+            build/test-results/**/*.trx
+            build/test-results/**/*.json
+
+#      - name: Upload build artifacts
+#        uses: actions/upload-artifact@v4
+#        with:
+#          name: Package
+#          path: build/libs

.gitignore

@@ -94,6 +94,7 @@ code/build.eclipse/
 
 # IntelliJ IDE
 .idea/
+.run/
 out/
 pcgendev.iml
 pcgen.iml

build.gradle

@@ -748,6 +748,10 @@ tasks.named("jre") {
     dependsOn downloadJRE, downloadJavaFXModules
 }
 
+tasks.withType(Test) {
+    testLogging.showStandardStreams = false
+}
+
 tasks.named("test", Test) {
     exclude 'pcgen/testsupport/**'
     useJUnitPlatform()
@@ -951,7 +955,7 @@ apply from: 'code/gradle/reporting.gradle'
 apply from: 'code/gradle/release.gradle'
 
 tasks.register("allTasks") {
-    dependsOn build, slowtest, javadoc, buildNsis, allReports
+    dependsOn build, slowtest, javadoc, allReports
     description = "Runs tasks build, slowtest, javadoc, buildNsis and allReports"
 }
 

code/gradle/release.gradle

@@ -420,7 +420,7 @@ tasks.register("sourcesJar", Jar) {
 }
 
 tasks.register("assembleArtifacts", Copy) {
-    dependsOn build, runtimeZip, sourcesJar, buildNsis
+    dependsOn build, runtimeZip, sourcesJar
 
     if (Os.isFamily(Os.FAMILY_MAC) || Os.isFamily(Os.FAMILY_UNIX))
     {
@@ -431,9 +431,6 @@ tasks.register("assembleArtifacts", Copy) {
     into releaseDir
     // buildNsis puts the exe into the release folder directly
 
-    from(layout.buildDirectory.dir("nsisRelease")){
-        include '*.exe'
-    }
     from(layout.buildDirectory.dir("libs")){
         include 'pcgen*-sources.jar'
     }

code/src/java/pcgen/cdom/base/Constants.java

@@ -28,7 +28,6 @@
 @SuppressWarnings("PMD.ConstantsInInterface")
 public interface Constants
 {
-
 	/********************************************************************
 	 * Static definitions of Equipment location strings
 	 ********************************************************************/
@@ -111,7 +110,7 @@ public interface Constants
 	String INTERNAL_WEAPON_PROF = "PCGENi_WEAPON_PROFICIENCY"; //$NON-NLS-1$
 
 	/** Line Separator. */
-	String LINE_SEPARATOR = System.getProperty("line.separator"); //$NON-NLS-1$
+	String LINE_SEPARATOR = System.lineSeparator(); //$NON-NLS-1$
 
 	/** The constant string "None". */
 	String NONE = "None"; //$NON-NLS-1$

code/src/java/pcgen/core/Globals.java

@@ -540,8 +540,8 @@ public static void clearCampaignsForRefresh()
 
 	/**
 	 * Check if enough data has been loaded to support character creation.
-	 * Will also report to the log the number of items of each of the 
-	 * necessary types that are currently loaded.  
+	 * Will also report to the log the number of items of each of the
+	 * necessary types that are currently loaded.
 	 * @return true or false
 	 */
 	public static boolean displayListsHappy()
@@ -722,7 +722,7 @@ public static boolean selectPaper(final String paperName)
 	}
 
 	/**
-	 * Apply the user's preferences to the initial state of the Globals.  
+	 * Apply the user's preferences to the initial state of the Globals.
 	 */
 	public static void initPreferences()
 	{
@@ -789,8 +789,8 @@ static List<? extends CDOMObject> sortPObjectList(final List<? extends CDOMObjec
 
 	/**
 	 * Sort Pcgen Object list by name
-	 * @param <T> 
-	 * 
+	 * @param <T>
+	 *
 	 * @param aList
 	 * @return Sorted list of Pcgen Objects
 	 */
@@ -1033,7 +1033,7 @@ else if (fType.equals("mac_user"))
 
 	private static int bonusParsing(final String l, final int level, int num, final PlayerCharacter aPC)
 	{
-		// should be in format levelnum,rangenum[,numchoices] 
+		// should be in format levelnum,rangenum[,numchoices]
 		final StringTokenizer aTok = new StringTokenizer(l, "|", false);
 		final int startLevel = Integer.parseInt(aTok.nextToken());
 		final String rangeLevelFormula = aTok.nextToken();

code/src/java/pcgen/core/PlayerCharacter.java

@@ -5477,7 +5477,13 @@ public int processOldMaxDex()
 	{
 		final int statBonus = (int) getStatBonusTo("MISC", "MAXDEX");
 		final Load load = getHouseRuledLoadType();
-		int bonus = (load == Load.MEDIUM) ? 2 : (load == Load.HEAVY) ? 1 : (load == Load.OVERLOAD) ? 0 : statBonus;
+		int bonus = switch (load)
+		{
+			case MEDIUM -> 3;
+			case HEAVY -> 1;
+			case OVERLOAD -> 0;
+			default -> statBonus;
+		};
 
 		// If this is still true after all the equipment has been
 		// examined, then we should use the Maximum - Maximum Dex modifier.

code/src/java/pcgen/gui2/PCGenFrame.java

@@ -1560,6 +1560,7 @@ public void run()
 			updateTitle();
 		}
 
+		// TODO there are no examples with licenses. Either remove this or add a test.
 		private void showLicenses()
 		{
 			PropertyContext context = PCGenSettings.OPTIONS_CONTEXT;
@@ -1576,11 +1577,8 @@ private void showLicenses()
 					{
 						showLicenseDialog(LanguageBundle.getString("in_specialLicenses"), licenses); //$NON-NLS-1$
 					}
-					for (String license : loader.getOtherLicenses())
-					{
-						showLicenseDialog(LanguageBundle.getString("in_specialLicenses"), license); //$NON-NLS-1$
-					}
-
+					loader.getOtherLicenses()
+							.forEach(license -> showLicenseDialog(LanguageBundle.getString("in_specialLicenses"), license)); //$NON-NLS-1$
 				}
 			}
 			if (loader.hasMatureCampaign() && context.initBoolean(PCGenSettings.OPTION_SHOW_MATURE_ON_LOAD, true))