这下应该真修好了吧

PBH-BTN · Jan 7, 2025 · b1865d1 · b1865d1
1 parent 7b55ccf
commit b1865d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/main/java/com/ghostchu/btn/sparkle/module/ping/PingController.java b/src/main/java/com/ghostchu/btn/sparkle/module/ping/PingController.java
@@ -73,8 +73,7 @@ public class PingController extends SparkleController {
 
     @PostMapping("/peers/submit")
     public ResponseEntity<String> submitPeers(@RequestBody @Validated BtnPeerPing ping) throws AccessDeniedException, UnknownHostException {
-        var cred = cred();
-        userApplicationService.updateUserApplicationLastAccessTime(cred);
+        var cred = userApplicationService.updateUserApplicationLastAccessTime(cred());
         var audit = new LinkedHashMap<String, Object>();
         audit.put("appId", cred.getAppId());
         if (isCredBanned(cred)) {
@@ -95,8 +94,7 @@ public ResponseEntity<String> submitPeers(@RequestBody @Validated BtnPeerPing pi
 
     @PostMapping("/histories/submit")
     public ResponseEntity<String> submitPeerHistories(@RequestBody @Validated BtnPeerHistoryPing ping) throws AccessDeniedException, UnknownHostException {
-        var cred = cred();
-        userApplicationService.updateUserApplicationLastAccessTime(cred);
+        var cred = userApplicationService.updateUserApplicationLastAccessTime(cred());
         var audit = new LinkedHashMap<String, Object>();
         audit.put("appId", cred.getAppId());
         if (isCredBanned(cred)) {
@@ -117,8 +115,7 @@ public ResponseEntity<String> submitPeerHistories(@RequestBody @Validated BtnPee
 
     @PostMapping("/bans/submit")
     public ResponseEntity<String> submitBans(@RequestBody @Validated BtnBanPing ping) throws AccessDeniedException, UnknownHostException {
-        var cred = cred();
-        userApplicationService.updateUserApplicationLastAccessTime(cred);
+        var cred = userApplicationService.updateUserApplicationLastAccessTime(cred());
         var audit = new LinkedHashMap<String, Object>();
         audit.put("appId", cred.getAppId());
         if (isCredBanned(cred)) {
@@ -138,8 +135,7 @@ public ResponseEntity<String> submitBans(@RequestBody @Validated BtnBanPing ping
 
     @GetMapping("/config")
     public ResponseEntity<Object> config() throws AccessDeniedException, JsonProcessingException, UnknownHostException {
-        var cred = cred();
-        userApplicationService.updateUserApplicationLastAccessTime(cred);
+        var cred = userApplicationService.updateUserApplicationLastAccessTime(cred());
         var audit = new LinkedHashMap<String, Object>();
         audit.put("appId", cred.getAppId());
         if (isCredBanned(cred)) {
@@ -173,8 +169,7 @@ public ResponseEntity<Object> config() throws AccessDeniedException, JsonProcess
 
     @GetMapping("/rules/retrieve")
     public ResponseEntity<String> rule() throws IOException, AccessDeniedException {
-        var cred = cred();
-        userApplicationService.updateUserApplicationLastAccessTime(cred);
+        var cred = userApplicationService.updateUserApplicationLastAccessTime(cred());
         var audit = new LinkedHashMap<String, Object>();
         audit.put("appId", cred.getAppId());
         if (isCredBanned(cred)) {

diff --git a/src/main/java/com/ghostchu/btn/sparkle/module/userapp/UserApplicationService.java b/src/main/java/com/ghostchu/btn/sparkle/module/userapp/UserApplicationService.java
@@ -123,13 +123,14 @@ public UserApplication editUserApplicationComment(Long id, String comment) throw
     @Transactional(Transactional.TxType.NOT_SUPPORTED)
     @Lock(value = LockModeType.OPTIMISTIC)
     @Retryable(retryFor = ObjectOptimisticLockingFailureException.class, backoff = @Backoff(delay = 100, multiplier = 2))
-    public void updateUserApplicationLastAccessTime(UserApplication userApplication) {
+    public UserApplication updateUserApplicationLastAccessTime(UserApplication userApplication) {
         userApplication.setLastAccessAt(OffsetDateTime.now());
         try {
-            userApplicationRepository.save(userApplication);
+            return userApplicationRepository.save(userApplication);
         } catch (Exception e) {
             log.info("Failed to update last access time for user application: {}", userApplication.getId(), e);
         }
+        return userApplication;
     }
 
     public UserApplicationDto toDto(UserApplication userApplication) {