Simplify and tidy up FieldRecord and netcdf output #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods to disentangle FieldRecord data format conversions
from netcdf input/output:
Add
get_array_full(fr::FieldRecord) -> Array, (dimnames...)
to convert a FieldRecord into an array suitable for writing to netcdf,
with corresponding FieldRecord constructor for the inverse operation.
Add
variable_is_constant(fr::FieldRecord)
to test whether a FieldRecord is actually time-independent,
and hence record dimension can be omitted when saving to netcdf
TODO PALEO still stores a record at each timestep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods to disentangle FieldRecord data format conversions from netcdf input/output:
Add:
to convert a FieldRecord into an array suitable for writing to netcdf, with corresponding FieldRecord constructor for the inverse operation.
to test whether a FieldRecord is actually time-independent, and hence record dimension can be omitted when saving to netcdf. TODO PALEO still stores a record at each timestep.