Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating next package to 15.1.3 and added copyfiles in dev dependency #112

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

codewithshinde
Copy link
Contributor

Changes:
upgraded next to 15.1.3

I have added copyfiles as a development dependency because the cp command is not supported in the Windows Command Prompt during the build process. This change ensures that our build script works seamlessly across different operating systems, including Windows.

…es as "cp" while building wont work on windows.
@Ovyerus
Copy link
Owner

Ovyerus commented Dec 29, 2024

I would rather not add another dependency just for copying; if you use PowerShell (specifically the more up to date PowerShell Core, not sure about the built in Windows PowerShell), it comes with a cp alias and can understand the -r flag just fine from what I can remember, so it should work fine here.

@codewithshinde
Copy link
Contributor Author

I would rather not add another dependency just for copying; if you use PowerShell (specifically the more up to date PowerShell Core, not sure about the built in Windows PowerShell), it comes with a cp alias and can understand the -r flag just fine from what I can remember, so it should work fine here.

I 100% Agree with your point, I have added it to maintain the repo for "Cross-Platform Consistency"
For users who may not be familiar with PowerShell, using a dedicated library can provide a more straightforward API or command-line interface.

I can remove the change of copyfiles, Is the next js upgrade good with you?

@Ovyerus
Copy link
Owner

Ovyerus commented Dec 29, 2024

Yeah the Next.js upgrade is fine.

If copying does turn out to be a bigger issue, a simpler script using fs.cp can probably be devised.

@codewithshinde
Copy link
Contributor Author

Yeah the Next.js upgrade is fine.

If copying does turn out to be a bigger issue, a simpler script using fs.cp can probably be devised.

I have added a script file instead.

@Ovyerus Ovyerus merged commit d854204 into Ovyerus:dev Dec 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants