ci: fix permissions issue in label-pr workflow #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
auto-merge
valarnin
approved these changes
Mar 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Small fix for the PR labeling workflow. It appears that the job that's supposed to run when a PR review is submitted [isn't removing the needs-review label](https://github.com/OverlayPlugin/cactbot/actions/runs/8132959713/job/22223972723) because it relies on a different GH event (`pull_request_review`) than the other jobs (`pull_request_target`), and therefore doesn't auto-inherit read/write permissions on PRs. Didn't pick this up in testing because it's affected by whether the PR originates from the same repo or a fork. This is hopefully the easy fix, but the [doc](https://docs.github.com/en/actions/security-guides/automatic-token-authentication) on maximum token permissions seems inconsistent with the [doc](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions) on the permissions attribute, so it might need a different approach if this doesn't work. 60e7f18
wexxlee
added a commit
that referenced
this pull request
Mar 10, 2024
#77 didn't quite do it, but this one should. Tested against PRs from a forked repo, and it now works fine. It's a little hacky in terms of a fix, but the reasons (and steps) are explained in a comment at the top of `label-pr-review.yml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for the PR labeling workflow. It appears that the job that's supposed to run when a PR review is submitted isn't removing the needs-review label because it relies on a different GH event (
pull_request_review) than the other jobs (pull_request_target), and therefore doesn't auto-inherit read/write permissions on PRs. Didn't pick this up in testing because it's affected by whether the PR originates from the same repo or a fork.This is hopefully the easy fix, but the doc on maximum token permissions seems inconsistent with the doc on the permissions attribute, so it might need a different approach if this doesn't work.