raidboss: fix bug with delays + countdowns #555
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
wexxlee
added a commit
to wexxlee/cactbot
that referenced
this pull request
Jan 5, 2025
|
LGTM in general, but it might be a good idea to add a test trigger to general.ts for this case that uses all three of the original properties on the vanguard trigger? |
I added one to |
xiashtra
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug (so far only occurring in Vanguard triggers) where
countdownSecondsis used in conjunction withdelaySeconds. Previously, the countdown end time was set to the trigger execution time + the countdown; however, if a delay is also present, the countdown would then be truncated by the amount of the delay (and would display past 0.0), since the alert duration is the greater of the original countdown value or duration.Fix tested and confirmed working in Vanguard and with some test triggers. Behavior now matches repo documentation.
cc: @xiashtra who I think (?) mentioned this issue originally