raidboss: FRU P2 initial triggers #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
xiashtra
reviewed
Dec 2, 2024
vayeetya
reviewed
Dec 2, 2024
xiashtra
reviewed
Dec 3, 2024
|
I have some more p2 stuff, but i'd like to test it a little more in-game tomorrow so I'll add it as a follow-up PR. |
valarnin
approved these changes
Dec 7, 2024
Sounds good. I'll merge and version bump tomorrow morning. I have the rest of P2 done and should be able to add most or all of P3 tomorrow. But there's going to be some judgment calls/feedback for some of that, and I want to do a little more in-game testing of the P3 stuff on Monday, so probably best to leave that for a separate PR. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2024
Some early p2 triggers -- tested in emulator + vod, but hasn't yet been tested in game (although I should be able to tomorrow night unless someone else gets to it first). 96dc7f2
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2024
Some early p2 triggers -- tested in emulator + vod, but hasn't yet been tested in game (although I should be able to tomorrow night unless someone else gets to it first). 96dc7f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some early p2 triggers -- tested in emulator + vod, but hasn't yet been tested in game (although I should be able to tomorrow night unless someone else gets to it first).