raidboss/oopsy: Add Byakko Unreal #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
💬ko
💬cn
raidboss
|
(I'm not sure how this work, but if the timeline text changes, should the |
That's entirely true, thank you for catching that. Since you mentioned it, I looked over the replacements and removed the now-superfluous |
xiashtra
reviewed
Nov 17, 2024
| type: 'HeadMarker', | ||
| netRegex: { id: '0004' }, | ||
| condition: Conditions.targetIsYou(), | ||
| alarmText: (_data, _matches, output) => output.text!(), |
There was a problem hiding this comment.
Suggested change
| alarmText: (_data, _matches, output) => output.text!(), | |
| alertText: (_data, _matches, output) => output.text!(), |
There was a problem hiding this comment.
This one I think is worth leaving as an alarm, since if the puddles are dropped poorly they will cause wipes. I don't feel super strongly about that, but I do think there's some merit to having this be alarmed.
xiashtra
requested changes
Nov 18, 2024
xiashtra
approved these changes
Nov 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
(Sorry I haven't been around for a while, life has been That Way. I'll get my Sphene normal package in place Soon. This one was some quick work I did because I did Unreal today.) Tested in-game. No visible issues. I made some small stylistic changes to the Stormblood files to better fit modern conventions, since in 2017 we were a lot more freeform about structure and style. ce14c90
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
(Sorry I haven't been around for a while, life has been That Way. I'll get my Sphene normal package in place Soon. This one was some quick work I did because I did Unreal today.) Tested in-game. No visible issues. I made some small stylistic changes to the Stormblood files to better fit modern conventions, since in 2017 we were a lot more freeform about structure and style. ce14c90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry I haven't been around for a while, life has been That Way. I'll get my Sphene normal package in place Soon. This one was some quick work I did because I did Unreal today.)
Tested in-game. No visible issues. I made some small stylistic changes to the Stormblood files to better fit modern conventions, since in 2017 we were a lot more freeform about structure and style.