Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raidboss: add Cenote Ja Ja Gural treasure dungeon #479

Merged
merged 7 commits into from
Nov 2, 2024
Merged

raidboss: add Cenote Ja Ja Gural treasure dungeon #479

merged 7 commits into from
Nov 2, 2024

Conversation

xiashtra
Copy link
Collaborator

No description provided.

@jacob-keller
Copy link

i'll be running some maps tomorrow and can give this a test run then to check for issues

jacob-keller
jacob-keller approved these changes Oct 22, 2024
View reviewed changes
Copy link

@jacob-keller jacob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has worked great for me the last few maps

jacob-keller
jacob-keller approved these changes Nov 2, 2024
View reviewed changes
Copy link

@jacob-keller jacob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge (tho I'm not sure my approval counts for the check)

@xiashtra
Copy link
Collaborator Author

xiashtra commented Nov 2, 2024

I think this is ready to merge (tho I'm not sure my approval counts for the check)

Unfortunately no, it'll need one of the other maintainers to approve first.

@valarnin
Copy link
Collaborator

valarnin commented Nov 2, 2024

I'm not familiar with the content, I've basically only done savage since it released and otherwise have been too busy to engage with other content, so I haven't been following this PR. I'll give it a once-over from a code standpoint tomorrow if another maintainer hasn't gotten to it by then.

wexxlee
wexxlee approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@wexxlee wexxlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this linger. I've been awol for a couple weeks with work travel, then getting super sick.

Haven't run this in game, but it sounds like @jacob-keller has, so this is just a style review. LGTM - a few stylistic comments, feel free to take or leave.

ui/raidboss/data/07-dt/map/cenote_ja_ja_gural.ts Outdated Show resolved Hide resolved
ui/raidboss/data/07-dt/map/cenote_ja_ja_gural.ts Outdated Show resolved Hide resolved
ui/raidboss/data/07-dt/map/cenote_ja_ja_gural.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the needs-review Awaiting review label Nov 2, 2024
@xiashtra xiashtra merged commit 91a2026 into OverlayPlugin:main Nov 2, 2024
10 checks passed
@xiashtra xiashtra deleted the cenote-ja-ja-gural branch November 2, 2024 08:40
github-actions bot pushed a commit that referenced this pull request Nov 2, 2024
triggers build: raidboss: add Cenote Ja Ja Gural treasure dungeon (#479…
d10df3f 
…) 91a2026
github-actions bot pushed a commit that referenced this pull request Nov 2, 2024
gh-pages build: raidboss: add Cenote Ja Ja Gural treasure dungeon (#479…
f3a7e4e 
…) 91a2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wexxlee wexxlee wexxlee approved these changes

@jacob-keller jacob-keller jacob-keller approved these changes

Assignees
No one assigned
Labels
💬cn 💬de 💬fr 💬ja 💬ko raidboss /ui/raidboss module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiashtra @jacob-keller @valarnin @wexxlee