util: add logging & err handling, docs updates #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valarnin
reviewed
Jan 4, 2024
valarnin
approved these changes
Jan 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
PR 3 of 3 (ref: #26 & #28) A handful of misc. improvements: - More robust console logging functionality to the util data scripts and xivapi library - Adds the 3 de-pythoned scripts to the `npm run util` CLI utility (along with a run-all option), and allows the user to specify a logging level to control console output - Better error capture throughout - Some minor code cleanup (mostly standardization around use of CSV/locale tables) - Corresponding docs updates to `util/README.md` and `docs/PatchUpdateChecklist.md` All scripts re-run, no data changes (as expected). This completes the work I had planned on this project, but in the course of pulling all this together, I wrote a super-lightweight CLI utility (integrated into `npm run util` ) to run custom queries against xivapi, along with some very basic filtering capability. It came in very handy for investigating data issues, and I could see it being useful if (when 👀 ) future patches create new data collisions or other issues. It needs some cleanup before it's ready for code review, but I'll likely add that as a future PR, time permitting. 2c7b245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 3 of 3 (ref: #26 & #28)
A handful of misc. improvements:
npm run utilCLI utility (along with a run-all option), and allows the user to specify a logging level to control console outpututil/README.mdanddocs/PatchUpdateChecklist.mdAll scripts re-run, no data changes (as expected).
This completes the work I had planned on this project, but in the course of pulling all this together, I wrote a super-lightweight CLI utility (integrated into
npm run util) to run custom queries against xivapi, along with some very basic filtering capability. It came in very handy for investigating data issues, and I could see it being useful if (when 👀 ) future patches create new data collisions or other issues. It needs some cleanup before it's ready for code review, but I'll likely add that as a future PR, time permitting.