-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update typescript and its friend to 5.1 #271
Conversation
Reported in #271 Some are not actually fixed, but leave a FIXME comment whenever someone are willing to fix it.
I'd like to land this so I can fix some of the underlying issues with my PR #462, as well as do some maintenance on outdated/vulnerable dependencies. Can you rebase to current main and fix the remaining linting/testing errors? |
Sure, it'd take some time to resolve linting / testing errors though. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tech changes here all look good.
Linting adjustments for triggers don't really match our normal patterns (early out for undefined) and should be adjusted.
I'm fine with merging with ESNext
module spec.
This PR takes the precedence of the Vite migration in #159
Summary
moduleResolution
set tobundler
which not requires.js
extension in the import statement.--experimental-specifier-resolution=node
to enable extensionless even in ESM mode,ts-node
implemented the feature as well.tsconfig.json
files for different requirement (ESLint, Mocha, etc)typescript-eslint
requiresparserOptions.project
to be setRemaining Issue
TypeScript report that type definisions of the package(resolved)chokidar
are not correct.It is a package required by webpack, maybe we should update webpack?Several files have not been reported errors by eslint before but now they are reported, dunno why but it is a good change to fix them.(fixed)