Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update typescript and its friend to 5.1 #271

Merged
merged 18 commits into from
Dec 6, 2024

Conversation

MaikoTan
Copy link
Collaborator

@MaikoTan MaikoTan commented Jul 24, 2024

This PR takes the precedence of the Vite migration in #159

Summary

  • Update TypeScript to 5.1.6
  • Remove ttypescript and the extreme long name extension
    • Since TypeScript above 5.0 support moduleResolution set to bundler which not requires .js extension in the import statement.
    • Node.js v20 support option --experimental-specifier-resolution=node to enable extensionless even in ESM mode, ts-node implemented the feature as well.
  • Some dependency should be updated for TypeScript v5.1
  • Added separated tsconfig.json files for different requirement (ESLint, Mocha, etc)
  • typescript-eslint requires parserOptions.project to be set

Remaining Issue

  • TypeScript report that type definisions of the package chokidar are not correct. (resolved)
    • It is a package required by webpack, maybe we should update webpack?
  • Several files have not been reported errors by eslint before but now they are reported, dunno why but it is a good change to fix them. (fixed)

@github-actions github-actions bot added util /util ci /.github/ test /test, /ui/test needs-review Awaiting review raidemulator /ui/raidemulator module labels Jul 24, 2024
MaikoTan added a commit that referenced this pull request Jul 26, 2024
Reported in #271

Some are not actually fixed, but leave a FIXME comment whenever someone
are willing to fix it.
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
Reported in #271

Some are not actually fixed, but leave a FIXME comment whenever someone
are willing to fix it. f0085c8
@valarnin
Copy link
Collaborator

I'd like to land this so I can fix some of the underlying issues with my PR #462, as well as do some maintenance on outdated/vulnerable dependencies.

Can you rebase to current main and fix the remaining linting/testing errors?

@github-actions github-actions bot removed the raidemulator /ui/raidemulator module label Dec 5, 2024
@MaikoTan
Copy link
Collaborator Author

MaikoTan commented Dec 5, 2024

Can you rebase to current main and fix the remaining linting/testing errors?

Sure, it'd take some time to resolve linting / testing errors though.

@github-actions github-actions bot added raidboss /ui/raidboss module config ui/config, ui/[module]/config labels Dec 5, 2024
@MaikoTan
Copy link
Collaborator Author

MaikoTan commented Dec 5, 2024

Can you rebase to current main and fix the remaining linting/testing errors?

Sure, it'd take some time to resolve linting / testing errors though.

Done

@MaikoTan MaikoTan requested a review from valarnin December 5, 2024 06:08
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tech changes here all look good.

Linting adjustments for triggers don't really match our normal patterns (early out for undefined) and should be adjusted.

I'm fine with merging with ESNext module spec.

ui/raidboss/data/07-dt/hunts/shaaloani.ts Outdated Show resolved Hide resolved
ui/raidboss/data/07-dt/hunts/shaaloani.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the needs-review Awaiting review label Dec 5, 2024
@github-actions github-actions bot added the needs-review Awaiting review label Dec 6, 2024
@MaikoTan MaikoTan requested a review from valarnin December 6, 2024 01:04
@github-actions github-actions bot removed the needs-review Awaiting review label Dec 6, 2024
@valarnin valarnin merged commit 67035e1 into OverlayPlugin:main Dec 6, 2024
21 checks passed
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Dec 6, 2024
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Dec 6, 2024
@MaikoTan MaikoTan deleted the update-ts branch December 6, 2024 05:48
@wexxlee wexxlee mentioned this pull request Dec 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci /.github/ config ui/config, ui/[module]/config raidboss /ui/raidboss module test /test, /ui/test util /util
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants