-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: UCOB timeline phase sync fixes #154
raidboss: UCOB timeline phase sync fixes #154
Conversation
88b2cde
to
a6a45a5
Compare
Rebase to main, and add another sync fix for Nael => Bahamut phase transition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one suggestion and a question about detecting the phase 3 jump based on Nael going untargetable. I probably won't be back in UCOB until after the next tier, so if this looks good to you in terms of the phase detection, good w/me.
Edit: Sorry, forgot to add: I think SpawnObject
would be a good add, but I'll take a look at the stuff you posted on the OP issue and leave any comments there.
Depends on #153, will rebase once that's merged.This cleans up and fixes the syncs for the HP %-based pushes in UCOB phase one, by instead detecting the Neurolink puddle drops.
Had to adjust the timeline a bit to allow the sync to work due to the original timeline not having proper phase definitions.
For reference, there are a few objects that get spawned in UCOB that I've seen up to my current prog point:
On zone init / after wipe:
During pull:
Hypernova
puddle? Timing is slightly off so not 100% sure, could be caused by animation delayI have left a
TODO
in the timeline to change theCombatantMemory
syncs to use a potential newSpawnObject
OP log line depending on how that side of the equation works out.