Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: UCOB timeline phase sync fixes #154

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

valarnin
Copy link
Collaborator

@valarnin valarnin commented May 26, 2024

Depends on #153, will rebase once that's merged.

This cleans up and fixes the syncs for the HP %-based pushes in UCOB phase one, by instead detecting the Neurolink puddle drops.

Had to adjust the timeline a bit to allow the sync to work due to the original timeline not having proper phase definitions.

For reference, there are a few objects that get spawned in UCOB that I've seen up to my current prog point:

On zone init / after wipe:

ID Description Count X Y (height, not reversed with Z) Z
001E8536 Unknown 1 0 0 18
001EA1A1 Unknown 3 0 0.0171 0
001E850B Unknown 1 0 0 -20
001EA1A1 Unknown 3 0 0 0

During pull:

ID Description
000006EB Unknown. Spawns ~8s into pull, and at the same time the 3rd Neurolink spawns
001E8910 Twister puddles
001E88FF Neurolink puddles
001E88FE Liquid Hell puddles
001E91D4 Wings of Salvation doom cleanse puddle
001E91C1 Looks like this is the Hypernova puddle? Timing is slightly off so not 100% sure, could be caused by animation delay
001EA7E5 Giant fireball for the phase transition to Bahamut Prime
001E9663 "pepperoni" towers in QMT

I have left a TODO in the timeline to change the CombatantMemory syncs to use a potential new SpawnObject OP log line depending on how that side of the equation works out.

@github-actions github-actions bot added raidboss /ui/raidboss module util /util test /test, /ui/test needs-review Awaiting review labels May 26, 2024
@valarnin valarnin force-pushed the ucob-phase1-timeline-fixes branch from 88b2cde to a6a45a5 Compare June 7, 2024 00:57
@valarnin
Copy link
Collaborator Author

valarnin commented Jun 7, 2024

Rebase to main, and add another sync fix for Nael => Bahamut phase transition

@github-actions github-actions bot removed util /util test /test, /ui/test labels Jun 7, 2024
@valarnin valarnin changed the title raidboss: UCOB phase1 timeline fixes raidboss: UCOB timeline phase sync fixes Jun 9, 2024
@valarnin valarnin requested a review from wexxlee June 9, 2024 16:55
Copy link
Collaborator

@wexxlee wexxlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one suggestion and a question about detecting the phase 3 jump based on Nael going untargetable. I probably won't be back in UCOB until after the next tier, so if this looks good to you in terms of the phase detection, good w/me.

Edit: Sorry, forgot to add: I think SpawnObject would be a good add, but I'll take a look at the stuff you posted on the OP issue and leave any comments there.

@github-actions github-actions bot removed the needs-review Awaiting review label Jun 9, 2024
@valarnin valarnin merged commit 079eb89 into OverlayPlugin:main Jun 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raidboss /ui/raidboss module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants