resources: Update netlog_defs filters (auto-generated)

[github-actions]

Caution

NOTE TO REVIEWERS:
Due to GitHub limitations, you must close & re-open this PR before merging to ensure pre-merge workflows (e.g. linters) are correctly triggered.**

This PR was auto-generated based on a recent repo commit to either resources/netlog_defs.ts or to a file in ui/raidboss/data.

It updates the analysis filter criteria to ensure all log line types currently being used by raidboss triggers/timelines are included in the log splitter's analysis filter (unless actively suppressed).

This update was triggered after finding the below uses of certain log line types. Please carefully review these uses to determine if including all log lines of these types in the analysis filter is appropriate.

You can instead change the include property to 'filter' (and add filters:), or to 'never' to suppress the log line type from the filter. Changes can be pushed to the PR branch before merging this PR.

RemovedCombatant

cactbot/ui/raidboss/data/04-sb/raid/o5n.ts

Lines 17 to 19 in 0f4ebe4

	id: 'O5N Stop Combat',
	type: 'RemovedCombatant',
	netRegex: { name: 'Phantom Train', capture: false },

cactbot/ui/raidboss/data/04-sb/raid/o5s.ts

Lines 17 to 19 in 0f4ebe4

	id: 'O5S Stop Combat',
	type: 'RemovedCombatant',
	netRegex: { name: 'Phantom Train', capture: false },

cactbot/ui/raidboss/data/04-sb/trial/shinryu-ex.ts

Lines 20 to 22 in 0f4ebe4

	id: 'ShinryuEx Heart Cleanup',
	type: 'RemovedCombatant',
	netRegex: { name: 'Shinryu', capture: false },

cactbot/ui/raidboss/data/04-sb/eureka/eureka_hydatos.txt

Line 13 in 0f4ebe4

0.0 "--Reset--" RemovedCombatant { name: "Proto Ozma" } window 0,100000 jump 0

cactbot/ui/raidboss/data/05-shb/ultimate/the_epic_of_alexander.txt

Line 49 in 0f4ebe4

196.0 "--sync--" RemovedCombatant { name: "Liquid Hand" } window 50,0

NetworkCancelAbility

cactbot/ui/raidboss/data/04-sb/eureka/eureka_hydatos.txt

Line 139 in 0f4ebe4

3154.9 "--sync--" NetworkCancelAbility { id: "3878", source: "Raiden" } window 40,0

cactbot/ui/raidboss/data/04-sb/eureka/eureka_hydatos.txt

Line 161 in 0f4ebe4

3341.7 "--sync--" NetworkCancelAbility { id: "3878", source: "Raiden" } window 40,0

cactbot/ui/raidboss/data/06-ew/ultimate/dragonsongs_reprise_ultimate.txt

Line 156 in 0f4ebe4

993.1 "--sync--" NetworkCancelAbility { id: "63C3", source: "King Thordan" } window 300,0

NetworkDoT

cactbot/ui/oopsyraidsy/data/06-ew/ultimate/dragonsongs_reprise_ultimate.ts

Lines 280 to 282 in 0f4ebe4

	id: 'DSR Pyretic',
	type: 'NetworkDoT',
	// Amazingly, the dot/hot line has the effect id for pyretic here. Most dots don't.

WasDefeated

cactbot/ui/raidboss/data/04-sb/eureka/eureka_anemos.ts

Lines 157 to 159 in 0f4ebe4

	id: 'Eureka Wraith Count',
	type: 'WasDefeated',
	netRegex: { target: 'Shadow Wraith', capture: false },

cactbot/ui/raidboss/data/04-sb/map/the_shifting_altars_of_uznair.ts

Lines 138 to 140 in 0f4ebe4

	id: 'Shifting Altars of Uznair Altar Totem Flames of Fury Cleanup',
	type: 'WasDefeated',
	netRegex: { target: 'Altar Totem', capture: false },

cactbot/ui/raidboss/data/05-shb/eureka/delubrum_reginae_savage.ts

Lines 2507 to 2509 in 0f4ebe4

	id: 'DelubrumSav Queen Ball Lightning Bubble',
	type: 'WasDefeated',
	netRegex: { target: 'Ball Lightning', capture: false },

cactbot/ui/raidboss/data/05-shb/eureka/delubrum_reginae_savage.txt

Line 315 in 0f4ebe4

6000.0 "--Reset--" WasDefeated { target: "Dahu" } window 0,2000 jump 0

NetworkEffectResult

cactbot/ui/raidboss/data/03-hw/raid/a11s.ts

Lines 349 to 351 in 0f4ebe4

	id: 'A11S Plasma Shield Shattered',
	type: 'NetworkEffectResult',
	netRegex: { name: 'Plasma Shield', currentHp: '0', capture: false },

StartsUsingExtra

cactbot/ui/raidboss/data/04-sb/ultimate/ultima_weapon_ultimate.ts

Lines 625 to 627 in 0f4ebe4

	id: 'UWU Ifrit Initial Radiant Plume Collector',
	type: 'StartsUsingExtra',
	netRegex: { id: '2B61' },

cactbot/ui/raidboss/data/05-shb/raid/e8s.ts

Lines 464 to 466 in 0f4ebe4

	id: 'E8S Icicle Impact',
	type: 'StartsUsingExtra',
	netRegex: { id: '4DA0' },

Caution

REMINDER:
Please don't forget to close & re-open this PR before merging to ensure pre-merge workflows are correctly triggered!

[wexxlee]

FWIW, my thoughts on these:
(I haven't tested this yet, but I think if we decide to make changes, we can just commit directly to the update-logdefs branch without needing to merge+do a follow-up PR)

RemovedCombatant

I think ok to add but filtered only to NPC combatants (same as AddedCombatant) - e.g.

    analysisOptions: {
      include: 'filter',
      filters: { id: '4.{7}' }, // NPC combatants only
      combatantIdFields: 2,
    },

NetworkCancelAbility

Seems pretty edge case, but I guess could be useful for phase jumps? If so, should def be filtered to NPC combatants only.

NetworkDoT

I think this can probably just be suppressed (e.g. 'never')?

WasDefeated

I think OK to include if filtered to NPC combatants.

NetworkEffectResult

Another one I think could be suppressed.

StartsUsingExtra

I think it should be included but filtered to NPC combatants to match the filter on 0x14 lines.

[valarnin]

I agree with most of these, except:

NetworkDoT

I think this can probably just be suppressed (e.g. 'never')?

I think this should be included but filter to only lines with effectId: '[^0][^\']*?' or something else indicating a valid effectId.

(realistically I would prefer to filter to both DoT && valid effectId but the filtering is || instead)

For numbers, across 33,289,262 lines dating back to 2024-01-08, 1,069,726 (3.2%) of those are NetworkDoT lines.
Across those 1,069,726 NetworkDoT lines, 785,262 (73.4%) of those have an effectId of 0, and 284,464 (26.6%) have a valid effectId.
So the rate of inclusion would be 0.85% of all lines.

[wexxlee]

NetworkDoT

I think this can probably just be suppressed (e.g. 'never')?

I think this should be included but filter to only lines with effectId: '[^0][^\']*?' or something else indicating a valid effectId.

(realistically I would prefer to filter to both DoT && valid effectId but the filtering is || instead)

Filtering can be && - if both field filters are in the same object, it's &&; if a different object, it's ||. Good example of this is on the logdef for 0x1A:

    analysisOptions: {
      include: 'filter',
      filters: [
        { // effect from environment/NPC applied to player
          sourceId: '[E4].{7}',
          targetId: '1.{7}',
        },
        { // known effectIds of interest
          effectId: ['B9A', '808'],
        },
      ],
      combatantIdFields: [5, 7],
    },

For numbers, across 33,289,262 lines dating back to 2024-01-08, 1,069,726 (3.2%) of those are NetworkDoT lines. Across those 1,069,726 NetworkDoT lines, 785,262 (73.4%) of those have an effectId of 0, and 284,464 (26.6%) have a valid effectId. So the rate of inclusion would be 0.85% of all lines.

Would it make sense to further filter id to playerIds (1.{7}), so we only pick up DoTs on players?

[valarnin]

Would it make sense to further filter id to playerIds (1.{7}), so we only pick up DoTs on players?

I'm ambivalent. We don't currently have any potential use for a DoT on an enemy but that might not always be the case in the future.

[valarnin]

Looks good aside from the potential regex issue.