Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Thaleia alliance FR Update #12

Merged
merged 1 commit into from
Dec 22, 2023
Merged

i18n: Thaleia alliance FR Update #12

merged 1 commit into from
Dec 22, 2023

Conversation

mooondark
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added raidboss /ui/raidboss module 💬fr labels Dec 22, 2023
@Bing-su Bing-su self-requested a review December 22, 2023 11:22
@mooondark
Copy link
Collaborator Author

Should I "Squash and merge" or I let @quisquous do it (like it was before the old repository) ?

@Bing-su
Copy link
Collaborator

Bing-su commented Dec 22, 2023

From now on, we're on our own.

Currently, merging pull requests requires one approval from anybody. Please feel encouraged to review anybody's PRs that you can. Translation pull requests can be approved without concern for correctness in that language, and only checking if they are not making unexpected changes elsewhere or to other languages. Admins can merge without approval in an emergency.

When you write a PR, ask someone to review it. People who live in similar time zones would be an option.

@mooondark mooondark merged commit f6242bd into OverlayPlugin:main Dec 22, 2023
6 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
triggers build: i18n: Thaleia alliance FR Update (#12) f6242bd
ce8f4f0
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
gh-pages build: i18n: Thaleia alliance FR Update (#12) f6242bd
12ab947
@mooondark mooondark deleted the FR_20231222 branch December 22, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bing-su Bing-su Bing-su approved these changes

Assignees
No one assigned
Labels
💬fr raidboss /ui/raidboss module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mooondark @Bing-su