forked from quisquous/cactbot
-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gh-pages build: ci: improve and automate issue/PR labels (#72)
(_edited on 03-01-2024_) With cactbot's transition to a community-maintained project, I'd like to propose some changes to the issue/PR labels to help with organization and automation. This PR includes _~a handful of workflow scripts~ an update to the existing PR labeling workflow script_ to automate some of the label management discussed below. I'm admittedly trying to strike a balance between adding things that will be useful and will keep the issue/PR lists scrubbed (especially if/when repo activity ramps up leading in to 7.0), but not overengineering. I'm not sure how well this proposal strikes that balance, so this is definitely a wide call for comments, suggestions, and pushback. NB: If we decide to go forward with this (or some version of this) proposal, it probably makes sense to throw this in a 'maintainers' guide doc or something similar. But I'd be inclined to tackle that with a follow-up PR. ## Issue Labels: Existing issue type labels (`bug`, `question`, `enhancement`) are automatically applied when a new issue is opened. `needs-review` is also automatically applied to all new issues (and can be manually removed once an issue is reviewed). I propose to keep that behavior, and add the following label options: | Label | Applied | Intent | |:------|:--------|:-------| | `pending info` | Manual | Used when we are waiting on more info from the issue opener. | | `cant repro` | Manual | Used when a bug cannot be reproduced and appears unique to the issue opener. | | `fix-me` | Manual & Automatic | Used to indicate a valid bug/feature request that should be addressed. (Auto-applied when issue linked to PR.) | | `not planned` | Manual | Used to indicate that a bug/requested feature is intended behavior, a system limitation, etc., and won't be addressed. | | _~`stale`~_ | _~Automatic~_ | _~Applied automatically to inactive issues (see discussion below) after a period of inactivity. If there is no further activity, they will be automatically closed.~_ | ## PR Labels: Similarly to issues, I propose to automatically label PRs with `needs-review` when opened and whenever a new commit is pushed to the PR _(until an approving review is submitted)_. That label ~can be manually removed by the reviewer once the PR has been initially reviewed~ _will be automatically removed whenever a maintainer submits a review (approving or otherwise)_. I also propose to add the following label option~s~: | Label | Applied | Intent | |:------|:--------|:-------| | `auto-merge` | Automatic | Toggled whenever a PR's auto-merge setting is changed (added visibility for reviewers before approving). | | _~`changes-requested`~_ | _~Manual~_ | _~Used when a reviewer has requested changes before merging. Can be manually removed once changes are committed & reviewed.~_ | | _~`review-complete`~_ | _~Automatic~_ | _~Automatically applied when an approving review is submitted.~_ | | _~`stale`~_ | _~Automatic~_ | _~Same as with issues (see discussion below).~_ | ## Supporting Workflow Scripts: This PR modifies the existing (now renamed) `labels.yaml` -> `label_pr.yml` script to automate this functionality, specifically: * If a PR is opened or a new commit is pushed: * auto-label.cjs will (continue to) add scope-related labels * auto_label.cjs will add `needs-review` unless the PR already has an approving review from a maintainer * Any linked issues will have the `fix-me` label applied to them. * If a review (approving or otherwise) is added by a maintainer, the `needs-review` label is removed. * If auto merge is enabled or disabled on the PR, the `auto-merge` label is added/removed. _~This PR includes some workflow scripts to help automate the label management discussed above.~_ * _~`label-linked-issues` - adds `fix-me` to an issue when it is linked to a PR.~_ * _~`label-pr-automerge` - toggles `auto-merge` on a PR whenever the auto-merge setting is changed.~_ * _~`label-pr-review` -~_ * _~Adds `review-complete` (and removes `needs-review`) when an approving review is submitted.~_ * _~Adds `needs-review` to a PR when opened or when a new commit is pushed (**unless** `review-complete` is present).~_ * _~`stale-daemon` - runs `actions/stale` every 4 hours and:~_ * _~Adds `stale` to any issue that has had no activity in 30 days and __does not have__ `needs-review` or `fix-me`.~_ * _~Adds `stale` to any PR that has had no activity in 60 days and __does not have__ `needs-review`.~_ * _~Removes `stale` from any issue/PR if there is subsequent activity.~_ * _~Closes any issue/PR that has been labeled `stale` for 7 days with no subsequent activity.~_ * _~Adds an explanatory comment to issues/PRs when marking as `stale` or closing.~_ b177af5
- Loading branch information
github-actions
committed
Mar 3, 2024
0 parents
commit eb77fa4
Showing
216 changed files
with
521,455 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Files in this folder are art reused from Final Fantasy XIV. | ||
|
||
FINAL FANTASY is a registered trademark of Square Enix Holdings Co., Ltd. | ||
|
||
Final Fantasy art and icons reused non-commercially under the | ||
[FINAL FANTASY® XIV Materials Usage License](https://support.na.square-enix.com/rule.php?id=5382). |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
We acquired them from the BigWigs World of Warcraft addon | ||
project, and were told these were contributed from an unknown | ||
source. We believe these sounds come from freesound.org, | ||
which would make them licensed under the Creative Commons | ||
License. | ||
|
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Files in this directory come from: https://overwatch.gamepedia.com and are used | ||
without modification. | ||
|
||
They are distributed under the Attribution-NonCommercial-ShareAlike 3.0 | ||
Unported (CC BY-NC-SA 3.0) license. Full license text can be found at | ||
https://creativecommons.org/licenses/by-nc-sa/3.0/ |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
These sounds from freesound.org and licensed via Creative Commons licenses. | ||
The details of each license along with source for each sound is listed below. | ||
All sounds have been converted from .wav to .webm for space. | ||
|
||
alarm.webm | ||
https://freesound.org/people/ZyryTSounds/sounds/219244/ | ||
http://creativecommons.org/publicdomain/zero/1.0/ | ||
modifications: shortened to first second | ||
|
||
amy/ | ||
http://www.freesound.org/people/Timbre/sounds/83033/ | ||
https://creativecommons.org/licenses/by-nc/3.0/ | ||
modifications: sound cut into separate files | ||
|
||
percussion_hit.webm | ||
https://freesound.org/people/Stumber/sounds/207863/ | ||
https://creativecommons.org/publicdomain/zero/1.0/ | ||
|
||
power_up.webm | ||
https://freesound.org/people/GameAudio/sounds/220173/ | ||
https://creativecommons.org/publicdomain/zero/1.0/ | ||
|
||
sonar.webm | ||
https://freesound.org/people/NoiseCollector/sounds/6164/ | ||
https://creativecommons.org/licenses/by/3.0/ | ||
|
||
water_drop.webm | ||
https://freesound.org/people/paespedro/sounds/174718/ | ||
https://creativecommons.org/publicdomain/zero/1.0/ |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.