CLR绑定:函数参数有多维数组报错修改 #730
Open
CLR绑定:函数参数有多维数组报错修改 #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLR绑定:函数参数有多维数组报错修改 NullReferenceException: Object reference not set to an instance of an object ILRuntime.CLR.TypeSystem.ILType.CheckGenericParams (ILRuntime.CLR.Method.ILMethod i, System.Collections.Generic.List`1[T] param, ILRuntime.CLR.TypeSystem.IType[] genericArguments, System.Boolean& match) (at Library/PackageCache/[email protected]/CLR/TypeSystem/ILType.cs:929)
liiir1985
requested changes
Oct 7, 2022
ILRuntime/CLR/Utils/Extensions.cs
Outdated
| @@ -53,6 +53,10 @@ public static List<IType> GetParamList(this MethodReference def, ILRuntime.Runti | |||
| { | |||
| name = t.FullName + "[]"; | |||
| } | |||
| else if (name == gp.Name + "[0...,0...]") | |||
There was a problem hiding this comment.
该修改会导致函数调用时产生额外的不必要GC Alloc，需要换个方式来识别，这个方法是高频执行方法，需要对这个主意
|
CLR绑定:函数参数有多维数组报错修改 |
|
CLR绑定:函数参数有多维数组报错修改 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLR绑定:函数参数有多维数组报错修改
NullReferenceException: Object reference not set to an instance of an object ILRuntime.CLR.TypeSystem.ILType.CheckGenericParams (ILRuntime.CLR.Method.ILMethod i, System.Collections.Generic.List`1[T] param, ILRuntime.CLR.TypeSystem.IType[] genericArguments, System.Boolean& match) (at Library/PackageCache/[email protected]/CLR/TypeSystem/ILType.cs:929)