Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos Across the Project and Rename defintions.py to definitions.py #847

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

benyissa
Copy link
Member

@benyissa benyissa commented Dec 6, 2024

This PR addresses and corrects all detected typos throughout the project to improve code quality and maintainability.

Key Change to Note:
The file defintions.py has been renamed to definitions.py to fix a typo in its name. Since this module is widely used across multiple agents, downstream projects may need to update their imports in future releases.

Impact:

  • Ensure consistent naming conventions across the project.
  • Consumers of this module must update their imports to prevent breaking changes.

Please review this PR to ensure there are no unintended impacts or overlooked references to the renamed file.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (a2e1eb6) to head (8ca4417).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ostorlab/utils/scanner_state_reporter.py 20.00% 4 Missing ⚠️
src/ostorlab/runtimes/definitions.py 25.00% 3 Missing ⚠️
src/ostorlab/agent/definitions.py 0.00% 2 Missing ⚠️
src/ostorlab/apis/add_scanner_state.py 0.00% 2 Missing ⚠️
src/ostorlab/cli/ci_scan/run/run.py 0.00% 1 Missing ⚠️
src/ostorlab/cli/scan/run/run.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   62.69%   62.69%           
=======================================
  Files         342      342           
  Lines       14491    14491           
=======================================
  Hits         9085     9085           
  Misses       5406     5406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benyissa benyissa marked this pull request as ready for review December 6, 2024 14:46
@benyissa benyissa requested a review from a team as a code owner December 6, 2024 14:46
@benyissa benyissa self-assigned this Dec 6, 2024
@3asm 3asm merged commit 65bf898 into main Dec 6, 2024
11 of 12 checks passed
@3asm 3asm deleted the fix/typos branch December 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants