-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop multiple or all scans at once. #844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 62.62% 62.69% +0.06%
==========================================
Files 342 342
Lines 14430 14491 +61
==========================================
+ Hits 9037 9085 +48
- Misses 5393 5406 +13 ☔ View full report in Codecov by Sentry. |
3asm
previously approved these changes
Dec 3, 2024
amine3
requested changes
Dec 3, 2024
Co-authored-by: Alaeddine Mesbahi <[email protected]>
Co-authored-by: Alaeddine Mesbahi <[email protected]>
…ns-at-once' into feature/stop-multiple-or-all-scans-at-once
amine3
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
scan stop
command to allow stopping multiple scans or all scans at once, improving the functionality from only stopping a single scan previously. The new feature provides more flexibility and efficiency in managing scans via the CLI.Changes Introduced
New Features:
--all
flag to stop all running scans:Error Handling:
--all
flag is provided, the command raises aUsageError
.Improvements:
--all
is used but no scans are running.Backward Compatibility:
Testing
Added new unit tests to ensure the functionality works as expected:
stop
method is called for each provided scan ID.--all
is used.--all
is used but no scans are found.