Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent version to GCP logs #840

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

benyissa
Copy link
Member

@benyissa benyissa commented Dec 2, 2024

When debugging production issues in GCP logs, it is crucial to identify the specific version of the agent associated with the logs. This helps confirm whether an issue has been fixed or to determine which version is affected.

Currently, the logs in GCP do not include the agent version, as shown in the following screenshot:

image

This PR adds functionality to include the agent version in the logs, ensuring better traceability and debugging efficiency.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.62%. Comparing base (7b3f06f) to head (b421425).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ostorlab/agent/agent.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   62.62%   62.62%           
=======================================
  Files         342      342           
  Lines       14430    14430           
=======================================
  Hits         9037     9037           
  Misses       5393     5393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benyissa benyissa self-assigned this Dec 2, 2024
@benyissa benyissa marked this pull request as ready for review December 2, 2024 10:42
@amine3 amine3 merged commit 2327850 into main Dec 2, 2024
11 of 12 checks passed
@amine3 amine3 deleted the feature/add_agent_version_to_gcp_logs branch December 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants