Fix open ports parsing from yaml. #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 62.71% 62.73% +0.02%
==========================================
Files 341 341
Lines 14299 14307 +8
==========================================
+ Hits 8967 8975 +8
Misses 5332 5332 ☔ View full report in Codecov by Sentry. |
rabsondev
approved these changes
Oct 25, 2024
amine3
approved these changes
Oct 25, 2024
Zakaria-Latif
approved these changes
Oct 25, 2024
| assert agent_definition.caps == ["NET_ADMIN"] | ||
| assert agent_definition.open_ports == [ | ||
| utils_defintions.PortMapping( | ||
| source_port=4242, |
There was a problem hiding this comment.
i think you may want to test with different ports so you make sure everything is in the right place
ohachimOs
reviewed
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
open_portsfield of theAgentDefinitionclass is of typePortMapping.When reading the raw yaml agent definition to create the
AgentDefinitioninstance, the current implementation doesn't convert the raw dict to the correspondingPortMappingobjects.This PR handles this cases in the
from_yamlclassmethod of theAgentDefinitionclass.