Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electrohold invalid TLD. #41

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix electrohold invalid TLD. #41

merged 1 commit into from
Jul 22, 2024

Conversation

3asm
Copy link
Member

@3asm 3asm commented Jul 22, 2024

The issue seems to be addressed in newer version of TLD. Added unit test verifying the fix.

The issue seems to be addressed in newer version of TLD.
Added unit test verifying the fix.
Copy link
Member

@ErebusZ ErebusZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see the tests, is the fix already added?

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (e62915d) to head (55d6293).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   97.39%   97.86%   +0.46%     
==========================================
  Files           4        4              
  Lines         269      281      +12     
==========================================
+ Hits          262      275      +13     
+ Misses          7        6       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3asm 3asm added the fixit! label Jul 22, 2024
@3asm
Copy link
Member Author

3asm commented Jul 22, 2024

As said in the description (please read it), the issue is fixed in the newer version of TLD lib.

@amine3 amine3 merged commit 7de7b82 into main Jul 22, 2024
5 checks passed
@amine3 amine3 deleted the fix/invalid_tld branch July 22, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants