Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Ensure all entries are unique & fix duplicates. #123

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

deadly-panda
Copy link
Member

Some entries; eg: PATH_TRAVERSAL, XPATH_INJECTION and XML_INJECTION were duplicated between the web & mobile.
This PR fixes the duplicates & adds a unit test to ensure this does not happen again.

Copy link
Contributor

@BlueSquare1 BlueSquare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should drop the risk rating of xpath injection, critical is too much.

Copy link
Member

@elyousfi5 elyousfi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@3asm
Copy link
Member

3asm commented Jan 25, 2024

Please resolve conflict.

@deadly-panda deadly-panda merged commit 37b0f6a into master Jan 26, 2024
3 checks passed
@deadly-panda deadly-panda deleted the fix/ensure_all_entries_are_unique branch January 26, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants