Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_inlines method being ignored #145

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

pawnhearts
Copy link
Contributor

No description provided.

@scottgigante
Copy link
Contributor

@OskarPersson could you please merge this PR? It's been sitting here for almost a year now and would be a great addition to this package.

@OskarPersson
Copy link
Owner

@scottgigante I would like to see a test added first

@scottgigante
Copy link
Contributor

I don't think anyone can write passing tests until #161 is merged.. anyhow I found https://django-nested-admin.readthedocs.io/en/latest/ which seems to solve my problems. Thanks

@pawnhearts
Copy link
Contributor Author

There weren't much tests back when I made that PR(there was just one which just tested if admin site loads). The thing is parent classes all work via that get_inline interface(which can be redefined and I had it redefined in my project). Just like other similar things in django(get_queryset, get_serializer_class, etc).
It's so simple there aren't much to test. That changelist_view still works when this method is redefined? That this method returns value of inlines if it's not?

@OskarPersson OskarPersson merged commit 14fddfe into OskarPersson:master Dec 15, 2023
@OskarPersson
Copy link
Owner

You're right. This is now merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants