Remove ArrayPool in ClientGrain.OnActivateAsync and replace with new allocated array #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrayPool returns an array which is at least the requested length, and so can have null elements at the end. Task.WhenAll throws an exception when provided an array with nulls.
michaelmcneilnet
requested review from
claylaut,
galvesribeiro,
zeus82 and
andrund
as code owners
ReubenBond
reviewed
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayPool returns an array which is at least the requested length, and so can have null elements at the end. Task.WhenAll throws an exception when provided an array with nulls.
Replaces #133 which is fixing the same issue but by keeping the arraypool and filtering out the nulls.
This solves #128