fix(graphic3d): fix graphic clear & destroy

Orillusion · Nov 21, 2024 · eff6082 · eff6082
1 parent 8b685b9
commit eff6082
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/graphic/package.json b/packages/graphic/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@orillusion/graphic",
-    "version": "0.2.3",
+    "version": "0.2.4",
     "author": "Orillusion",
     "description": "Orillusion Graphic Plugin",
     "main": "./dist/graphic.umd.js",

diff --git a/packages/graphic/renderer/Graphic3DBatchRenderer.ts b/packages/graphic/renderer/Graphic3DBatchRenderer.ts
@@ -97,7 +97,14 @@ export class Graphic3DBatchRenderer extends RenderNode {
         }
     }
 
+    public clear(){
+        this.shapes.clear();
+        this.mDirtyData = true;
+    }
+
     public nodeUpdate(view: View3D, passType: PassType, renderPassState: RendererPassState, clusterLightingBuffer?: ClusterLightingBuffer) {
+        if(this.isDestroyed)
+            return
         if (this.mDirtyData) {
             let offset = 0;
             let posAttrData = this.geometry.getAttribute(VertexAttributeName.position);
@@ -139,4 +146,8 @@ export class Graphic3DBatchRenderer extends RenderNode {
         this.mDirtyData = true;
         return shape;
     }
+
+    public destroy(force?: boolean): void {
+        super.destroy(force);
+    }
 }
diff --git a/packages/graphic/renderer/Graphic3DRender.ts b/packages/graphic/renderer/Graphic3DRender.ts
@@ -437,8 +437,8 @@ export class Graphic3D extends Object3D {
      * Erase all drawn graphics
      */
     public ClearAll() {
-        this.mLineRender.shapes.clear();
-        this.mFillRender.shapes.clear();
+        this.mLineRender.clear();
+        this.mFillRender.clear();
     }
 
     /**